Skip to content

update namespace pytest, make model weights not be all zeros #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

jmitrevs
Copy link
Contributor

Description

The pytest for namespaces actually did not actually set namespaces. This is pytest bug-fix. I also made the default model not have all 0 weights, which could potentially hide problems

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • Other (Specify) - test fix

Tests

This updates already existing tests that were not making the appropriate test.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs jmitrevs added the bug label Jul 15, 2025
@vloncar vloncar merged commit e5b1f17 into main Jul 16, 2025
7 of 9 checks passed
@vloncar vloncar deleted the namepace-pytest-fix branch July 16, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants